switch mapping to openMINDS Python classes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set all undefined/non discussed to None
|
@Peyman-N I reduced to what we currently know. Some PRs in instances are still missing for making the mapping run. |
|
@Peyman-N please replace the respective code in the conversion for the mapping (using openMINDS python extract instance by name function) Note for Technique you need to try / loop over these types AnalysisTechnique, StimulationApproach, StimulationTechnique or Technique |
|
@Peyman-N I forgot MRIPulseSequence in the list of technique types to loop over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to solve / tackle #7
Suggestion:
TYPE.by_name("INSTANCENAME")For2. Maybe introduce utility function to make instance reference and adding instance to collection (optional) at the same time.
@apdavison @Peyman-N please let me know if you agree with this approach before I continue with this PR.